Adds and use the component to display picked files during a new transfer #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR/issue depends on:
|
Thanks to this the newly added files are visible and you can see them being added, else they're hidden outside the screen and you don't see any movement
LunarX
force-pushed
the
display-picked-files
branch
from
aa3e3b2 to
f2f6fae
Compare
KevinBoulongne
requested changes
Oct 17, 2024
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/CrossCircleButton.kt
Outdated
Show resolved
Hide resolved
tevincent
reviewed
Oct 17, 2024
Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]>
LunarX
force-pushed
the
display-picked-files
branch
from
d4440e8 to
776a4c9
Compare
# Conflicts: # app/build.gradle.kts # app/src/main/java/com/infomaniak/swisstransfer/ui/components/Buttons.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt
sirambd
requested changes
Oct 17, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
|
Fix Sonar issues |
KevinBoulongne
requested changes
Oct 18, 2024
# Conflicts: # app/src/main/java/com/infomaniak/swisstransfer/ui/components/Buttons.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt
LunarX
force-pushed
the
display-picked-files
branch
2 times, most recently
from
eea7fcc to
8262a8f
Compare
LunarX
force-pushed
the
display-picked-files
branch
from
3619793 to
da57824
Compare
|
sirambd
approved these changes
Oct 18, 2024
tevincent
approved these changes
Oct 18, 2024
KevinBoulongne
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it displays picked files without copying them to the app's local storage. This will come in a second PR
Depends on #85